Update unix socket transport to use WebSocket upgrade#19244
Merged
willwang-openai merged 1 commit intomainfrom Apr 24, 2026
Merged
Update unix socket transport to use WebSocket upgrade#19244willwang-openai merged 1 commit intomainfrom
willwang-openai merged 1 commit intomainfrom
Conversation
This was referenced Apr 24, 2026
bolinfest
approved these changes
Apr 24, 2026
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
please just clarify that one test assertion
| let (mut websocket, response) = client_async("ws://localhost/rpc", stream) | ||
| .await | ||
| .expect("websocket upgrade should complete"); | ||
| assert_eq!(response.status().as_u16(), 101); |
Collaborator
There was a problem hiding this comment.
please add a third arg to this assert to explain what being equal to 101 "proves" (that the server agreed to switch protocols?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo test -p codex-app-server transport::unix_socket_testsjust fmtgit diff --check