chore: apply truncation policy to unified_exec#19247
Merged
Conversation
pakrym-oai
reviewed
Apr 24, 2026
pakrym-oai
reviewed
Apr 24, 2026
| stdin_output.output.len() | ||
| ); | ||
| assert!( | ||
| stdin_output.original_token_count.unwrap_or_default() > 50, |
Collaborator
There was a problem hiding this comment.
How do we know it's not global truncation?
Collaborator
Author
There was a problem hiding this comment.
changed to look at RawResponseItems, since those arent truncated by ContextManager. if its truncated by then, it must have happened at the unified_exec level, as intended.
pakrym-oai
reviewed
Apr 24, 2026
pakrym-oai
approved these changes
Apr 24, 2026
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were not respecting turn's
truncation_policyto clamp output tokens forunified_execandwrite_stdin.this meant truncation was only being applied by
ContextManagerbefore the output was stored in-memory (so it was being truncated from model-visible context), but the full output was persisted to rollout on disk.now we respect that
truncation_policyandContextManager-level truncation remains a backup.Tests
added tests, tested locally.