[codex] add non-local thread store regression harness#19266
Merged
wiltzius-openai merged 6 commits intomainfrom Apr 24, 2026
Merged
[codex] add non-local thread store regression harness#19266wiltzius-openai merged 6 commits intomainfrom
wiltzius-openai merged 6 commits intomainfrom
Conversation
96e969d to
f085e64
Compare
wiltzius-openai
added a commit
that referenced
this pull request
Apr 24, 2026
Contributor
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
wiltzius-openai
added a commit
that referenced
this pull request
Apr 24, 2026
wiltzius-openai
added a commit
that referenced
this pull request
Apr 24, 2026
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 24, 2026
…ness + thread-store harness - anomalyco/opencode#24179: session-scoped permission bridge for external providers (merge-after-nits) - anomalyco/opencode#24162: desktop health-check exponential backoff (request-changes; loopback gate dropped, no_proxy widened) - openai/codex#19389: npm update prompt readiness gate (merge-after-nits) - openai/codex#19266: non-local thread-store regression harness (merge-after-nits)
2a73ee1 to
c68ca75
Compare
starr-openai
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note I could not find a good way to also ensure there were no filesystem reads that didn't go through threadstore. I explored a more elaborate sandboxed-subprocess approach but it isn't platform portable and felt like it wasn't (yet) worth it.