Skip to content

[codex] add non-local thread store regression harness#19266

Merged
wiltzius-openai merged 6 commits intomainfrom
wiltzius/codex/non-local-thread-store-regression
Apr 24, 2026
Merged

[codex] add non-local thread store regression harness#19266
wiltzius-openai merged 6 commits intomainfrom
wiltzius/codex/non-local-thread-store-regression

Conversation

@wiltzius-openai
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai commented Apr 24, 2026

  • Add an integration test that guarantees nothing gets written to codex home dir or sqlite when running a rollout with a non-local ThreadStore
  • Add an in-memory "spy" ThreadStore for tests like this

Note I could not find a good way to also ensure there were no filesystem reads that didn't go through threadstore. I explored a more elaborate sandboxed-subprocess approach but it isn't platform portable and felt like it wasn't (yet) worth it.

@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/non-local-thread-store-regression branch from 96e969d to f085e64 Compare April 24, 2026 03:38
@wiltzius-openai wiltzius-openai marked this pull request as ready for review April 24, 2026 03:45
@wiltzius-openai wiltzius-openai requested a review from a team as a code owner April 24, 2026 03:45
wiltzius-openai added a commit that referenced this pull request Apr 24, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Bojun-Vvibe added a commit to Bojun-Vvibe/oss-contributions that referenced this pull request Apr 24, 2026
…ness + thread-store harness

- anomalyco/opencode#24179: session-scoped permission bridge for external providers (merge-after-nits)
- anomalyco/opencode#24162: desktop health-check exponential backoff (request-changes; loopback gate dropped, no_proxy widened)
- openai/codex#19389: npm update prompt readiness gate (merge-after-nits)
- openai/codex#19266: non-local thread-store regression harness (merge-after-nits)
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/non-local-thread-store-regression branch from 2a73ee1 to c68ca75 Compare April 24, 2026 21:06
@wiltzius-openai wiltzius-openai merged commit 588f7a9 into main Apr 24, 2026
25 checks passed
@wiltzius-openai wiltzius-openai deleted the wiltzius/codex/non-local-thread-store-regression branch April 24, 2026 22:45
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants