Skip to content

[codex] Migrate thread turns list to thread store#19280

Open
wiltzius-openai wants to merge 1 commit intowiltzius/codex/non-local-thread-store-regressionfrom
wiltzius/codex/thread-turns-list-store-read
Open

[codex] Migrate thread turns list to thread store#19280
wiltzius-openai wants to merge 1 commit intowiltzius/codex/non-local-thread-store-regressionfrom
wiltzius/codex/thread-turns-list-store-read

Conversation

@wiltzius-openai
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai commented Apr 24, 2026

  • Migrate thread/turns/list history loading to ThreadStore::read_thread(... include_history: true ...), with loaded-thread fallback through live thread history.
  • Preserve active turn merging and existing pagination/cursor behavior while removing direct rollout path resolution from the endpoint.
  • Keep v2 thread/list pathless-store friendly by converting StoredThread directly to API Thread, and add regression coverage for pathless store history/listing.

@wiltzius-openai wiltzius-openai changed the title wiltzius/codex/thread turns list store read [codex] Migrate thread turns list to thread store Apr 24, 2026
@wiltzius-openai wiltzius-openai marked this pull request as ready for review April 24, 2026 04:25
@wiltzius-openai wiltzius-openai requested a review from a team as a code owner April 24, 2026 04:25
@wiltzius-openai wiltzius-openai changed the base branch from main to wiltzius/codex/thread-store-fork-resume April 24, 2026 04:31
@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

💡 Codex Review

let result = if let Some(path) = path {
self.thread_store
.read_thread_by_rollout_path(StoreReadThreadByRolloutPathParams {
rollout_path: path.clone(),
include_archived: true,
include_history,
})
.await

P1 Badge Keep path-based fork/resume working with remote thread stores

thread/resume and thread/fork are documented to accept path, but this helper now routes every path-based request through ThreadStore::read_thread_by_rollout_path(). RemoteThreadStore hard-fails that method, so enabling experimental_thread_store_endpoint turns valid path-based requests into internal errors instead of loading the local rollout as before.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-fork-resume branch 2 times, most recently from 079c897 to 9298207 Compare April 24, 2026 18:39
Base automatically changed from wiltzius/codex/thread-store-fork-resume to main April 24, 2026 20:51
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-turns-list-store-read branch from 6addbab to 98077a0 Compare April 24, 2026 21:17
@wiltzius-openai wiltzius-openai changed the base branch from main to wiltzius/codex/non-local-thread-store-regression April 24, 2026 21:17
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-turns-list-store-read branch from 98077a0 to 42ed3b4 Compare April 24, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant