Hide unsupported MCP bearer_token from config schema#19294
Merged
etraut-openai merged 1 commit intomainfrom Apr 24, 2026
Merged
Hide unsupported MCP bearer_token from config schema#19294etraut-openai merged 1 commit intomainfrom
etraut-openai merged 1 commit intomainfrom
Conversation
sayan-oai
approved these changes
Apr 24, 2026
|
Thanks for the quick fix! The PR scope matches the schema/runtime mismatch I was seeing. |
etraut-openai
deleted the
etraut/hide-unsupported-mcp-bearer-token-schema
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19275.
Codex runtime rejects inline MCP
bearer_tokenconfig entries and asks users to configurebearer_token_env_varinstead, but the generated config schema still advertisedmcp_servers.<name>.bearer_tokenas a supported field. That made editor/schema validation disagree with runtime validation.This keeps
bearer_tokeninRawMcpServerConfigso Codex can continue producing the targeted runtime error for recent or existing configs, but skips the field during schemars generation. The checked-incore/config.schema.jsonfixture now exposesbearer_token_env_varwithout exposing unsupported inlinebearer_token.Verification
config_schema_hides_unsupported_inline_mcp_bearer_tokento assert the generated schema hidesbearer_tokenwhile preservingbearer_token_env_var.cargo test -p codex-config.cargo test -p codex-core config_schema.