[codex] Add token usage to turn tracing spans#19432
Merged
charley-openai merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
charley-openai
force-pushed
the
dev/charley/turn-token-tracing
branch
from
b693e55 to
c9b64ef
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
charley-openai
force-pushed
the
dev/charley/turn-token-tracing
branch
from
c9b64ef to
f7ddddc
Compare
charley-openai
force-pushed
the
dev/charley/turn-token-tracing
branch
from
f7ddddc to
12b293e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Slow Codex turns are easier to debug when token usage is visible in the trace itself, without joining against separate analytics. This adds token usage to existing turn-handling spans for regular user turns only.
Example turn
What Changed
Added response-level token fields on completed handle_responses spans:
gen_ai.usage.input_tokens
gen_ai.usage.cache_read.input_tokens
gen_ai.usage.output_tokens
codex.usage.reasoning_output_tokens
codex.usage.total_tokens
Added aggregate token fields on regular turn spans:
codex.turn.token_usage.*
Added an explicit regular-turn opt-in via SessionTask::records_turn_token_usage_on_span() so this is not coupled to span-name strings.
Testing
cargo test -p codex-otelcargo test -p codex-core turn_and_completed_response_spans_record_token_usagejust fmtjust fix -p codex-corejust fix -p codex-otelKnown status:
cargo test -p codex-corewas attempted and failed in unrelated existing areas: config approvals, request-permissions, git-info ordering, and subagent metadata persistence.