stop blocking unified_exec on Windows#19435
Merged
iceweasel-oai merged 4 commits intomainfrom Apr 29, 2026
Merged
Conversation
iceweasel-oai
changed the title
Collaborator
Author
|
@codex review |
jif-oai
approved these changes
Apr 28, 2026
iceweasel-oai
force-pushed
the
codex/windows-unified-exec-opt-in
branch
from
a2609b9 to
e1f9bda
Compare
Updates the plan mode nudge test to pass the new `duration_ms` argument to task completion. Co-authored-by: Codex <noreply@openai.com>
…-exec-opt-in # Conflicts: # codex-rs/tui/src/chatwidget/tests/plan_mode.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unified_execdefault-off on Windows unless the feature is explicitly enabledshell_type = unified_exectoshell_commandwhen the feature is disabledWhy
Now that the session/long-lived process backend is implemented for the Windows sandbox, we don't need to hard disable it anymore. We will be rolling out slowly using a feature gate.
Impact
This allows manual Windows opt-in in CLI and app-backed flows while preserving the existing default-off behavior for Windows users.