Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e5744dd4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3a74ae4 to
e63758a
Compare
dylan-hurd-oai
approved these changes
Apr 24, 2026
pakrym-oai
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The VS Code extension and desktop app do not need the full TUI binary, and
codex-app-serveris materially smaller than standalonecodex. We still want to publish it as an official release artifact, but building it by tacking another--binonto the existing releasecargo buildinvocations would lengthen those jobs.This change keeps
codex-app-serveron its own release bundle so it can build in parallel with the existingcodexand helper bundles.What changed
.github/workflows/rust-release.ymlbundle-aware so each macOS and Linux MUSL target now builds either the existingprimarybundle (codexandcodex-responses-api-proxy) or a standaloneapp-serverbundle (codex-app-server).scripts/stage_npm_packages.pyandcodex-cli/scripts/install_native_deps.pycontinue to find release assets under the paths they already expect, while giving the new app-server artifacts distinct names.app-serverbundle to.github/workflows/rust-release-windows.yml, and updated the final Windows packaging job to download, sign, stage, and archivecodex-app-server.exealongside the existing release binaries..github/actions/linux-code-sign/action.yml,.github/actions/macos-code-sign/action.yml, and.github/actions/windows-code-sign/action.ymlso each workflow row declares its binaries once and reuses that list for build, signing, and staging.codex-app-serverto.github/dotslash-config.jsonso releases also publish a generated DotSlash manifest for the standalone app-server binary.primarybundle;codex-app-serverships as the regular standalone archives and DotSlash manifest.Verification
python3+yaml.safe_load(...)..github/dotslash-config.jsonlocally withpython3+json.loads(...).codex-app-serveris built separately on macOS, Linux MUSL, and Windows, while the existing npm staging and Windowscodexzip bundling contracts remain intact.