Conversation
044a4ba to
d1d7b7d
Compare
d97d1de to
46339ac
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46339ace0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c224de8 to
689b3d1
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 689b3d11db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8688838 to
7316d24
Compare
39325b1 to
209c925
Compare
Summary
plugin/uninstallrequest form using requiredpluginIdplus optionalremoteMarketplaceName, while preserving localpluginIduninstall.codex_core_plugins::remote::uninstall_remote_pluginfor the deployed ChatGPT plugin backend uninstall path and validates the backend returns the same id withenabled: false.Tests
just write-app-server-schemajust fmtcargo test -p codex-app-server-protocol plugin_uninstall_params_serialization_omits_force_remote_synccargo test -p codex-app-server plugin_uninstall --test allcargo test -p codex-app-server plugin_uninstallcargo build -p codex-cliCODEX_BIN=/Users/xli/code/codex/codex-rs/target/debug/codex python3 /Users/xli/.codex/skills/xli-test-marketplace-api/scripts/run_marketplace_api_matrix.py(44 pass / 0 fail)just fix -p codex-app-server-protocol -p codex-app-server -p codex-tuijust fix -p codex-app-server