Skip to content

Add remote plugin uninstall API#19456

Merged
xli-oai merged 11 commits intomainfrom
xli-codex/remote-plugin-uninstall
Apr 28, 2026
Merged

Add remote plugin uninstall API#19456
xli-oai merged 11 commits intomainfrom
xli-codex/remote-plugin-uninstall

Conversation

@xli-oai
Copy link
Copy Markdown
Contributor

@xli-oai xli-oai commented Apr 24, 2026

Summary

  • Adds the remote plugin/uninstall request form using required pluginId plus optional remoteMarketplaceName, while preserving local pluginId uninstall.
  • Adds codex_core_plugins::remote::uninstall_remote_plugin for the deployed ChatGPT plugin backend uninstall path and validates the backend returns the same id with enabled: false.
  • Routes app-server remote uninstall through feature checks, remote plugin id validation, backend mutation, local downloaded cache deletion, cache clearing, docs, and regenerated protocol schemas.

Tests

  • just write-app-server-schema
  • just fmt
  • cargo test -p codex-app-server-protocol plugin_uninstall_params_serialization_omits_force_remote_sync
  • cargo test -p codex-app-server plugin_uninstall --test all
  • cargo test -p codex-app-server plugin_uninstall
  • cargo build -p codex-cli
  • CODEX_BIN=/Users/xli/code/codex/codex-rs/target/debug/codex python3 /Users/xli/.codex/skills/xli-test-marketplace-api/scripts/run_marketplace_api_matrix.py (44 pass / 0 fail)
  • just fix -p codex-app-server-protocol -p codex-app-server -p codex-tui
  • just fix -p codex-app-server

@xli-oai xli-oai added the oai PRs contributed by OpenAI employees label Apr 24, 2026 — with ChatGPT Codex Connector
@xli-oai xli-oai force-pushed the xli-codex/remote-plugin-uninstall branch from 044a4ba to d1d7b7d Compare April 24, 2026 23:44
@xli-oai xli-oai marked this pull request as ready for review April 26, 2026 23:10
@xli-oai xli-oai force-pushed the xli-codex/remote-plugin-uninstall branch 2 times, most recently from d97d1de to 46339ac Compare April 28, 2026 03:59
Comment thread codex-rs/app-server/src/codex_message_processor/plugins.rs Outdated
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46339ace0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/src/remote.rs Outdated
@xli-oai xli-oai force-pushed the xli-codex/remote-plugin-uninstall branch 2 times, most recently from c224de8 to 689b3d1 Compare April 28, 2026 05:57
@xli-oai
Copy link
Copy Markdown
Contributor Author

xli-oai commented Apr 28, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 689b3d11db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/src/remote.rs Outdated
Comment thread codex-rs/app-server/src/codex_message_processor/plugins.rs Outdated
@xli-oai xli-oai force-pushed the xli-codex/remote-plugin-uninstall branch from 8688838 to 7316d24 Compare April 28, 2026 07:10
@xli-oai xli-oai force-pushed the xli-codex/remote-plugin-uninstall branch from 39325b1 to 209c925 Compare April 28, 2026 08:05
@xli-oai xli-oai merged commit 803705f into main Apr 28, 2026
25 checks passed
@xli-oai xli-oai deleted the xli-codex/remote-plugin-uninstall branch April 28, 2026 10:27
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

oai PRs contributed by OpenAI employees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants