Streamline plugin, apps, and skills handlers#19490
Merged
pakrym-oai merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
633d4a6 to
13c6797
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
This commit removes async fn send_internal_error(...) but leaves many calls like self.send_internal_error(...) intact. As a result, codex-app-server no longer type-checks (method not found on CodexMessageProcessor) and the build is blocked. Re-introduce the helper (or replace all remaining callsites) before merging.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
13c6797 to
244a3ff
Compare
Base automatically changed from
pakrym/streamline-appserver-error-handling
to
main
April 26, 2026 22:10
244a3ff to
c6c2d92
Compare
c6c2d92 to
a09b616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The plugin, app, and skills handlers had a lot of repeated
send_error/returnbranches that made the success path hard to scan. This slice keeps behavior the same while moving fallible steps into local response-producing helpers, so the request boundary can send one result.What Changed
codex-rs/app-server/src/codex_message_processor/plugins.rsto returnResult<*Response, JSONRPCErrorError>from helper methods and callsend_resultonce.codex-rs/app-server/src/codex_message_processor.rs.Verification
cargo check -p codex-app-servercargo test -p codex-app-server --test all v2::app_list -- --test-threads=1cargo test -p codex-app-server --test all v2::plugin_ -- --test-threads=1cargo test -p codex-app-server --test all v2::skills_list -- --test-threads=1