Skip to content

Streamline plugin, apps, and skills handlers#19490

Merged
pakrym-oai merged 1 commit intomainfrom
pakrym/appserver-errors-plugins-apps-skills
Apr 27, 2026
Merged

Streamline plugin, apps, and skills handlers#19490
pakrym-oai merged 1 commit intomainfrom
pakrym/appserver-errors-plugins-apps-skills

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

@pakrym-oai pakrym-oai commented Apr 25, 2026

Why

The plugin, app, and skills handlers had a lot of repeated send_error/return branches that made the success path hard to scan. This slice keeps behavior the same while moving fallible steps into local response-producing helpers, so the request boundary can send one result.

What Changed

  • Converted plugin list/install/uninstall handlers in codex-rs/app-server/src/codex_message_processor/plugins.rs to return Result<*Response, JSONRPCErrorError> from helper methods and call send_result once.
  • Added local error-mapping helpers for plugin install/uninstall and marketplace failures.
  • Applied the same mechanical shape to app list, skills list/config, and marketplace add/remove/upgrade handlers in codex-rs/app-server/src/codex_message_processor.rs.

Verification

  • cargo check -p codex-app-server
  • cargo test -p codex-app-server --test all v2::app_list -- --test-threads=1
  • cargo test -p codex-app-server --test all v2::plugin_ -- --test-threads=1
  • cargo test -p codex-app-server --test all v2::skills_list -- --test-threads=1

@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-plugins-apps-skills branch from 633d4a6 to 13c6797 Compare April 25, 2026 03:09
@pakrym-oai pakrym-oai changed the title Streamline plugin app-server handlers Streamline plugin, apps, and skills handlers Apr 25, 2026
@pakrym-oai pakrym-oai marked this pull request as ready for review April 25, 2026 04:00
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

self.send_internal_error(

P0 Badge Restore send_internal_error helper to compile app-server

This commit removes async fn send_internal_error(...) but leaves many calls like self.send_internal_error(...) intact. As a result, codex-app-server no longer type-checks (method not found on CodexMessageProcessor) and the build is blocked. Re-introduce the helper (or replace all remaining callsites) before merging.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-plugins-apps-skills branch from 13c6797 to 244a3ff Compare April 25, 2026 04:10
Base automatically changed from pakrym/streamline-appserver-error-handling to main April 26, 2026 22:10
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-plugins-apps-skills branch from 244a3ff to c6c2d92 Compare April 26, 2026 23:08
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-plugins-apps-skills branch from c6c2d92 to a09b616 Compare April 26, 2026 23:15
@pakrym-oai pakrym-oai merged commit 4ed22fc into main Apr 27, 2026
25 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/appserver-errors-plugins-apps-skills branch April 27, 2026 17:18
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant