Streamline thread start handler#19492
Merged
pakrym-oai merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
9cfedc6 to
2a102a7
Compare
a35af4e to
91f4e5d
Compare
91f4e5d to
b4c0c48
Compare
2a102a7 to
2d38a30
Compare
b4c0c48 to
35256b6
Compare
2ecea71 to
a6f9880
Compare
212b3b9 to
abf4831
Compare
a6f9880 to
37de240
Compare
37de240 to
c641ef2
Compare
8419a48 to
4355894
Compare
c641ef2 to
571c6c6
Compare
571c6c6 to
559a855
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The thread start handler mixed request validation, thread construction, dynamic-tool validation, and JSON-RPC error emission in one nested flow. Returning request errors from the helper path makes the successful setup path easier to follow.
What Changed
thread/starthandling incodex-rs/app-server/src/codex_message_processor.rsso helper methods returnResultand the handler emits one result.send_errorbranches.Verification
cargo check -p codex-app-servercargo test -p codex-app-server --test all v2::dynamic_tools -- --test-threads=1cargo test -p codex-app-server --test all v2::turn_start -- --test-threads=1