Skip to content

Streamline thread start handler#19492

Merged
pakrym-oai merged 1 commit intomainfrom
pakrym/appserver-errors-thread-start
Apr 27, 2026
Merged

Streamline thread start handler#19492
pakrym-oai merged 1 commit intomainfrom
pakrym/appserver-errors-thread-start

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

@pakrym-oai pakrym-oai commented Apr 25, 2026

Why

The thread start handler mixed request validation, thread construction, dynamic-tool validation, and JSON-RPC error emission in one nested flow. Returning request errors from the helper path makes the successful setup path easier to follow.

What Changed

  • Reworked thread/start handling in codex-rs/app-server/src/codex_message_processor.rs so helper methods return Result and the handler emits one result.
  • Moved dynamic-tool validation failures into returned JSON-RPC errors instead of local send_error branches.
  • Preserved the existing thread creation and task-spawning behavior.

Verification

  • cargo check -p codex-app-server
  • cargo test -p codex-app-server --test all v2::dynamic_tools -- --test-threads=1
  • cargo test -p codex-app-server --test all v2::turn_start -- --test-threads=1

@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-thread-start branch from 9cfedc6 to 2a102a7 Compare April 25, 2026 03:09
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-account-exec branch from a35af4e to 91f4e5d Compare April 25, 2026 03:09
@pakrym-oai pakrym-oai changed the title Streamline thread start app-server handlers Streamline thread start handler Apr 25, 2026
@pakrym-oai pakrym-oai marked this pull request as ready for review April 25, 2026 04:00
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-account-exec branch from 91f4e5d to b4c0c48 Compare April 25, 2026 04:10
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-thread-start branch from 2a102a7 to 2d38a30 Compare April 25, 2026 04:10
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-account-exec branch from b4c0c48 to 35256b6 Compare April 25, 2026 04:15
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-thread-start branch 2 times, most recently from 2ecea71 to a6f9880 Compare April 26, 2026 23:08
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-account-exec branch 2 times, most recently from 212b3b9 to abf4831 Compare April 26, 2026 23:15
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-thread-start branch from a6f9880 to 37de240 Compare April 26, 2026 23:15
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-thread-start branch from 37de240 to c641ef2 Compare April 27, 2026 17:22
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-account-exec branch 2 times, most recently from 8419a48 to 4355894 Compare April 27, 2026 18:45
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-thread-start branch from c641ef2 to 571c6c6 Compare April 27, 2026 18:45
Base automatically changed from pakrym/appserver-errors-account-exec to main April 27, 2026 19:03
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-thread-start branch from 571c6c6 to 559a855 Compare April 27, 2026 20:38
@pakrym-oai pakrym-oai merged commit c5e2921 into main Apr 27, 2026
25 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/appserver-errors-thread-start branch April 27, 2026 20:56
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant