Streamline thread read handlers#19494
Merged
pakrym-oai merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-mutations
branch
from
da2717b to
b8828ca
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-read
branch
from
f0dde8e to
7799914
Compare
pakrym-oai
changed the title
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-read
branch
from
7799914 to
fd812db
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-mutations
branch
from
558676d to
8f1b0a0
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-read
branch
3 times, most recently
from
cdb702f to
eea7c29
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-mutations
branch
from
1c40d3a to
e89693c
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-mutations
branch
from
e89693c to
c4b7cab
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-read
branch
from
eea7c29 to
820705f
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-mutations
branch
from
c4b7cab to
6001c85
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-read
branch
2 times, most recently
from
5b5b247 to
eb6945d
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-mutations
branch
from
6001c85 to
016897c
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-read
branch
from
eb6945d to
d75151a
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-mutations
branch
from
016897c to
869e8b6
Compare
Base automatically changed from
pakrym/appserver-errors-thread-mutations
to
main
April 27, 2026 21:18
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-read
branch
from
d75151a to
0a6b2e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The thread read/list handlers mostly assemble views, but their error handling was interleaved with response emission. Returning view-building errors from the helper path keeps those handlers focused on data assembly.
What Changed
ThreadReadViewErrorto JSON-RPC errors incodex-rs/app-server/src/codex_message_processor.rs.Verification
cargo check -p codex-app-servercargo test -p codex-app-server --test all conversation_summary -- --test-threads=1