Streamline MCP handlers#19496
Merged
pakrym-oai merged 1 commit intopakrym/appserver-errors-thread-resume-forkfrom Apr 27, 2026
Merged
Streamline MCP handlers#19496pakrym-oai merged 1 commit intopakrym/appserver-errors-thread-resume-forkfrom
pakrym-oai merged 1 commit intopakrym/appserver-errors-thread-resume-forkfrom
Conversation
pakrym-oai
force-pushed
the
pakrym/appserver-errors-mcp
branch
from
b9ce629 to
03c30b8
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
from
58cf3c8 to
5308b02
Compare
pakrym-oai
changed the title
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
from
5308b02 to
a548a0f
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-mcp
branch
from
03c30b8 to
bdfcca9
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
from
a548a0f to
d8792fc
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-mcp
branch
2 times, most recently
from
8056186 to
f3290ec
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
from
d8792fc to
67e573a
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-mcp
branch
from
f3290ec to
3c9686e
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
from
67e573a to
9dfa99f
Compare
This was referenced Apr 27, 2026
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
from
9dfa99f to
eaf38ae
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-mcp
branch
2 times, most recently
from
0de7bb7 to
ef966b4
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
from
13117fc to
8053487
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-mcp
branch
2 times, most recently
from
4d451bd to
9541603
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
2 times, most recently
from
0f3ad06 to
c55f80b
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-mcp
branch
from
9541603 to
0cc9bde
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-thread-resume-fork
branch
from
c55f80b to
b236a5e
Compare
pakrym-oai
force-pushed
the
pakrym/appserver-errors-mcp
branch
from
0cc9bde to
867fb28
Compare
pakrym-oai
merged commit 11fa611
into
pakrym/appserver-errors-thread-resume-fork
37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The MCP request handlers had repeated local JSON-RPC error emission around validation and manager calls. Returning those errors directly makes the normal response path much easier to scan.
What Changed
codex-rs/app-server/src/codex_message_processor.rs.send_error/returnbranches with returned JSON-RPC errors where that flattens control flow.Verification
cargo check -p codex-app-servercargo test -p codex-app-server --test all v2::mcp_resource -- --test-threads=1cargo test -p codex-app-server --test all v2::mcp_tool -- --test-threads=1cargo test -p codex-app-server --test all v2::mcp_server_status -- --test-threads=1