Streamline turn and realtime handlers#19497
Merged
pakrym-oai merged 1 commit intomainfrom Apr 27, 2026
Merged
Conversation
6fad0e6 to
9de37de
Compare
b9ce629 to
03c30b8
Compare
03c30b8 to
bdfcca9
Compare
5728267 to
5d14bae
Compare
8056186 to
f3290ec
Compare
cc036aa to
bd31008
Compare
f3290ec to
3c9686e
Compare
This was referenced Apr 27, 2026
bd31008 to
a39db7c
Compare
0de7bb7 to
ef966b4
Compare
a39db7c to
8b59896
Compare
ef966b4 to
4d451bd
Compare
13a8275 to
e48222a
Compare
9541603 to
0cc9bde
Compare
e48222a to
74eaf21
Compare
0cc9bde to
867fb28
Compare
74eaf21 to
47b736e
Compare
Base automatically changed from
pakrym/appserver-errors-mcp
to
pakrym/appserver-errors-thread-resume-fork
April 27, 2026 21:50
Base automatically changed from
pakrym/appserver-errors-thread-resume-fork
to
main
April 27, 2026 22:04
47b736e to
ce5a9ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Turn and realtime handlers had nested validation and send-error branches that made the request path longer than the behavior warranted. This slice keeps the same request semantics while letting the handlers return errors from the failing step.
What Changed
codex-rs/app-server/src/codex_message_processor.rs.Verification
cargo check -p codex-app-servercargo test -p codex-app-server --test all v2::turn_start -- --test-threads=1cargo test -p codex-app-server --test all v2::turn_steer -- --test-threads=1cargo test -p codex-app-server --test all v2::thread_inject_items -- --test-threads=1