Skip to content

Streamline turn and realtime handlers#19497

Merged
pakrym-oai merged 1 commit intomainfrom
pakrym/appserver-errors-turn-realtime
Apr 27, 2026
Merged

Streamline turn and realtime handlers#19497
pakrym-oai merged 1 commit intomainfrom
pakrym/appserver-errors-turn-realtime

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

@pakrym-oai pakrym-oai commented Apr 25, 2026

Why

Turn and realtime handlers had nested validation and send-error branches that made the request path longer than the behavior warranted. This slice keeps the same request semantics while letting the handlers return errors from the failing step.

What Changed

  • Streamlined turn start, injected item, and turn steer request handling in codex-rs/app-server/src/codex_message_processor.rs.
  • Applied the same result-returning shape to realtime session response handlers.
  • Preserved existing request validation and thread-manager interactions.

Verification

  • cargo check -p codex-app-server
  • cargo test -p codex-app-server --test all v2::turn_start -- --test-threads=1
  • cargo test -p codex-app-server --test all v2::turn_steer -- --test-threads=1
  • cargo test -p codex-app-server --test all v2::thread_inject_items -- --test-threads=1

@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch from 6fad0e6 to 9de37de Compare April 25, 2026 03:09
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-mcp branch from b9ce629 to 03c30b8 Compare April 25, 2026 03:09
@pakrym-oai pakrym-oai marked this pull request as ready for review April 25, 2026 04:00
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-mcp branch from 03c30b8 to bdfcca9 Compare April 25, 2026 04:10
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch 2 times, most recently from 5728267 to 5d14bae Compare April 25, 2026 04:15
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-mcp branch 2 times, most recently from 8056186 to f3290ec Compare April 26, 2026 23:08
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch 2 times, most recently from cc036aa to bd31008 Compare April 26, 2026 23:15
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-mcp branch from f3290ec to 3c9686e Compare April 26, 2026 23:15
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch from bd31008 to a39db7c Compare April 27, 2026 17:22
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-mcp branch 2 times, most recently from 0de7bb7 to ef966b4 Compare April 27, 2026 18:45
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch from a39db7c to 8b59896 Compare April 27, 2026 18:45
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-mcp branch from ef966b4 to 4d451bd Compare April 27, 2026 20:38
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch 2 times, most recently from 13a8275 to e48222a Compare April 27, 2026 21:01
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-mcp branch 2 times, most recently from 9541603 to 0cc9bde Compare April 27, 2026 21:19
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch from e48222a to 74eaf21 Compare April 27, 2026 21:19
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-mcp branch from 0cc9bde to 867fb28 Compare April 27, 2026 21:31
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch from 74eaf21 to 47b736e Compare April 27, 2026 21:31
Base automatically changed from pakrym/appserver-errors-mcp to pakrym/appserver-errors-thread-resume-fork April 27, 2026 21:50
Base automatically changed from pakrym/appserver-errors-thread-resume-fork to main April 27, 2026 22:04
@pakrym-oai pakrym-oai force-pushed the pakrym/appserver-errors-turn-realtime branch from 47b736e to ce5a9ce Compare April 27, 2026 22:05
@pakrym-oai pakrym-oai merged commit e903d00 into main Apr 27, 2026
25 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/appserver-errors-turn-realtime branch April 27, 2026 22:22
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant