Record MCP result telemetry on mcp.tools.call spans#19509
Merged
Conversation
6e660ee to
2f334c4
Compare
b3d7a9b to
1325338
Compare
sayan-oai
approved these changes
Apr 28, 2026
1325338 to
eabd9a7
Compare
This was referenced Apr 28, 2026
owenlin0
approved these changes
Apr 28, 2026
eabd9a7 to
b70ca9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What Changed
_meta["codex/telemetry"]["span"]and records it on themcp.tools.callspan.codex.mcp.target.idandcodex.mcp.user_flow.triggered, with strict type checks and bounded target ID length.Verification
codex-rs/core/src/mcp_tool_call_tests.rs