Keep slash command popup columns stable while scrolling#19511
Merged
etraut-openai merged 1 commit intomainfrom Apr 25, 2026
Merged
Keep slash command popup columns stable while scrolling#19511etraut-openai merged 1 commit intomainfrom
etraut-openai merged 1 commit intomainfrom
Conversation
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 25, 2026
- openai/codex#19524 merge-as-is (codex-mcp public surface trim) - openai/codex#19511 merge-as-is (slash command popup column stability) - BerriAI/litellm#26497 merge-as-is (chatgpt responses preserve text/parallel_tool_calls)
canvrno-oai
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #19499.
The slash-command popup recalculated the command-name column from only the rows visible in the current viewport. That made the description column shift horizontally while scrolling through
/commands whenever longer command names entered or left the visible window.What Changed
codex-rs/tui/src/bottom_pane/command_popup.rsnow uses the shared selection-popupAutoAllRowscolumn-width mode for both height measurement and rendering. This keeps the command description column based on the full filtered slash-command list instead of the current viewport.Verification
cargo test -p codex-tui bottom_pane::command_popup