Skip to content

[codex] Order codex-mcp items by visibility#19526

Merged
aibrahim-oai merged 7 commits intomainfrom
dev/order-codex-mcp-items
Apr 25, 2026
Merged

[codex] Order codex-mcp items by visibility#19526
aibrahim-oai merged 7 commits intomainfrom
dev/order-codex-mcp-items

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

Why

The visibility cleanup in the base PR reduced what codex-mcp exposes, but several files still made reviewers read private support machinery before the public or crate-facing entry points. This ordering pass makes each file easier to scan: exported API first, crate-visible MCP internals next, then private helpers in breadth-first order from the higher-level MCP flows to leaf utilities.

What Changed

  • Reordered codex-mcp exports so the runtime, configuration, snapshot, auth, and helper surfaces are grouped by visibility and reader importance.
  • Moved public and crate-visible MCP items ahead of private helpers in the auth, MCP planning/snapshot, connection manager, and tool-name modules.
  • Kept the change mechanical, with no behavior changes intended.

Verification

  • cargo check -p codex-mcp

Bojun-Vvibe added a commit to Bojun-Vvibe/oss-contributions that referenced this pull request Apr 25, 2026
- openai/codex#19526 (merge-as-is): codex-mcp visibility-ordered
  re-export pass; pure mechanical move companion to the surface
  trim. lib.rs reorganized into runtime/config/snapshot/auth
  groups with mod declarations relegated to file bottom.

- BerriAI/litellm#26495 (merge-after-nits): non-chat health-check
  handlers (image/video/embedding/transcription/rerank/ocr/batch)
  inherited spurious max_tokens injection, breaking dall-e-* and
  gpt-image-1 health checks with 400. Fix widens
  _filter_model_params with additional_keys_to_remove and
  threads a _non_chat_filter() closure through the affected
  handlers. PR carries 8800 lines of dev-branch drift that
  needs rebasing out before merge.

- continuedev/continue#12206 (merge-as-is): two-line fix to the
  AGENTS.md → AGENT.md → CLAUDE.md fallback loop in
  loadMarkdownRules.ts. The break was outside the success branch
  so the loop stopped on iteration 1 unconditionally — CLAUDE.md
  was silently never loaded when AGENTS.md was missing.

- ollama/ollama#15808 (merge-as-is): server/sched.go panic on
  model-mismatch-after-eviction held s.loadedMu across the
  panic, deadlocking deferred handlers. Patch unlocks before
  panic and pins ModelPath() to a local for message stability.
Bojun-Vvibe added a commit to Bojun-Vvibe/oss-contributions that referenced this pull request Apr 25, 2026
Lede counter through-drip-38 → through-drip-40. Eight new rows
spliced into per-repo tables for openai/codex, BerriAI/litellm,
continuedev/continue, ollama/ollama, charmbracelet/crush,
anomalyco/opencode, All-Hands-AI/OpenHands, cline/cline.

PRs: openai/codex#19526, BerriAI/litellm#26495,
continuedev/continue#12206, ollama/ollama#15808,
charmbracelet/crush#2693, anomalyco/opencode#24259,
OpenHands/OpenHands#14099, cline/cline#10403.
@aibrahim-oai aibrahim-oai marked this pull request as ready for review April 25, 2026 13:21
Base automatically changed from dev/minimize-codex-mcp-visibility to main April 25, 2026 13:36
@aibrahim-oai aibrahim-oai merged commit 022f81d into main Apr 25, 2026
25 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/order-codex-mcp-items branch April 25, 2026 14:17
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant