[codex] Bypass managed network for escalated exec#19595
Merged
viyatb-oai merged 3 commits intomainfrom Apr 25, 2026
Merged
Conversation
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Collaborator
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
bolinfest
reviewed
Apr 25, 2026
Collaborator
|
I think this is the right change, though I'm a little uncomfortable that these three files require similar changes: I don't see a great way to consolidate them, but it admittedly takes effort to ensure we are applying this sort of logic consistently across our various shell tools. |
Co-authored-by: Codex noreply@openai.com
bolinfest
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sandbox_permissions = "require_escalated"is treated as an explicit request to approve the command and run it outside the filesystem/platform sandbox. Before this change, shell and unified exec still registered managed network approval context and could inject Codex-managed proxy state into the child process, which meant an approved escalated command could still hit a second network approval path.This PR makes that escalation boundary consistent: once a command is explicitly approved to run outside the sandbox, Codex does not also route that process through the managed network proxy.
Security impact
Command/filesystem sandbox approval now implies network approval for that command. If an untrusted command or script is allowed to run with
require_escalated, its network calls are unsandboxed: Codex-managed network allowlists and denylists are not respected for that process, so the command can exfiltrate any data it can read.What changed
SandboxPermissions::RequireEscalated.network: Noneinto shell, zsh-fork shell, and unified exec sandbox preparation for explicitly escalated requests.CODEX_NETWORK_PROXY_ACTIVEis present, while preserving user proxy env when the Codex marker is absent.Verification
cargo test -p codex-core explicit_escalationcargo clippy -p codex-core --all-targets -- -D warnings