Skip to content

Fix codex-core config test type paths#19726

Merged
pakrym-oai merged 1 commit intomainfrom
pakrym/fix-main-build-full-ci
Apr 26, 2026
Merged

Fix codex-core config test type paths#19726
pakrym-oai merged 1 commit intomainfrom
pakrym/fix-main-build-full-ci

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

@pakrym-oai pakrym-oai commented Apr 26, 2026

Summary:

  • Update config tests to reference config requirement types from codex_config after the loader split.

Tests:

  • just fmt
  • cargo build -p codex-core --tests
  • cargo clippy -p codex-core --tests -- -D warnings

@pakrym-oai pakrym-oai requested a review from a team as a code owner April 26, 2026 22:41
@pakrym-oai pakrym-oai enabled auto-merge (squash) April 26, 2026 22:47
@bolinfest bolinfest self-requested a review April 26, 2026 22:48
bolinfest
bolinfest approved these changes Apr 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@pakrym-oai pakrym-oai disabled auto-merge April 26, 2026 22:58
@pakrym-oai pakrym-oai merged commit ba159cb into main Apr 26, 2026
43 of 50 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/fix-main-build-full-ci branch April 26, 2026 22:58
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bolinfest bolinfest bolinfest approved these changes

@aibrahim-oai aibrahim-oai aibrahim-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pakrym-oai @bolinfest @aibrahim-oai