Preserve assistant phase for replayed messages#19832
Merged
friel-openai merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
friel-openai
force-pushed
the
fix/inter-agent-phase-recording
branch
from
d490430 to
c3d92b1
Compare
ResponseInputItem::Message can contain assistant-authored history that is later converted into ResponseItem::Message. Preserve phase across that boundary instead of inferring phase from message content. InterAgentCommunication::to_response_input_item records inter-agent mailbox messages as commentary because they are assistant-authored in-between updates, not completed final answers. This follows the assistant phase guidance in https://developers.openai.com/api/docs/guides/deployment-checklist#set-up-the-assistant-phase-parameter. Co-authored-by: Codex <noreply@openai.com>
friel-openai
force-pushed
the
fix/inter-agent-phase-recording
branch
from
c3d92b1 to
b2a6f1c
Compare
jif-oai
approved these changes
Apr 28, 2026
| content: vec![ContentItem::OutputText { | ||
| text: serde_json::to_string(self).unwrap_or_default(), | ||
| }], | ||
| phase: Some(MessagePhase::Commentary), |
Collaborator
There was a problem hiding this comment.
Can you add a test for this that locks it and make sure we don't have regressions?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR preserves
ResponseItem::Message.phasewhen a message is converted throughResponseInputItem::Message, and recordsInterAgentCommunication::to_response_input_item()asMessagePhase::Commentaryat the inter-agent message source.The prior fork-based PR included unrelated Bazel workflow edits. This PR intentionally contains only the response-phase change.
Context
The OpenAI API deployment checklist says follow-up requests should preserve assistant
phase: https://developers.openai.com/api/docs/guides/deployment-checklist#set-up-the-assistant-phase-parameterWe found this while debugging forked-agent prompt caching. Replayed inter-agent mailbox items could cross the
ResponseInputItem::Message->ResponseItem::Messageboundary without their assistant phase, which made the same assistant history replay with different phases across resumed or forked sessions.Validation
cd codex-rs && just fmtcd codex-rs && cargo test -p codex-protocolcd codex-rs && just fix -p codex-protocolcd codex-rs && just fix -p codex-corecd codex-rs && just argument-comment-lint