Skip to content

ci: migrate Bazel setup away from archived setup-bazelisk#19851

Merged
bolinfest merged 1 commit intomainfrom
pr19851
Apr 27, 2026
Merged

ci: migrate Bazel setup away from archived setup-bazelisk#19851
bolinfest merged 1 commit intomainfrom
pr19851

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Apr 27, 2026

Why

All Bazel CI jobs are currently blocked in the setup-bazelisk step while trying to download Bazelisk. bazelbuild/setup-bazelisk is archived, and its README now recommends migrating to bazel-contrib/setup-bazel, so leaving our workflows on the archived action leaves CI exposed to exactly this sort of outage.

Because v8-canary now consumes the shared local setup-bazel-ci action, that workflow also needs to trigger when the action changes. Without that follow-up, Bazel bootstrap regressions specific to the V8 canary path could be skipped by the workflow path filters.

What Changed

  • Switched .github/actions/setup-bazel-ci/action.yml from bazelbuild/setup-bazelisk to bazel-contrib/setup-bazel, pinned to 0.19.0.
  • Left bazelisk-version unset so GitHub-hosted runners can use their preinstalled Bazelisk instead of downloading 1.x at job start.
  • Updated .github/workflows/rusty-v8-release.yml and .github/workflows/v8-canary.yml to use the shared setup-bazel-ci action instead of referencing setup-bazelisk directly.
  • Added .github/actions/setup-bazel-ci/** to the pull_request and push path filters in .github/workflows/v8-canary.yml so changes to the shared Bazel setup action still run the canary workflow.
  • Kept the existing repository-cache and Windows-specific Bazel setup logic intact.

This keeps Bazel version selection anchored by .bazelversion while removing the failing dependency on the archived setup action.

Verification

  • Searched .github/ to confirm there are no remaining setup-bazelisk references.
  • Parsed the updated workflow and action YAML locally with Ruby's YAML.load_file.

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e902ba021

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


- name: Set up Bazel
uses: bazelbuild/setup-bazelisk@b39c379c82683a5f25d34f0d062761f62693e0b2 # v3
uses: ./.github/actions/setup-bazel-ci
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include setup-bazel-ci in v8-canary path filters

Now that this job depends on the local ./.github/actions/setup-bazel-ci action, the pull_request/push paths filters at the top of v8-canary.yml are incomplete: they still do not include the action path. As a result, PRs (and pushes) that change setup-bazel-ci can skip v8-canary entirely, so Bazel bootstrap regressions for V8 builds can merge without this workflow running. Add .github/actions/setup-bazel-ci/** (or equivalent) to both path-filter lists.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@bolinfest bolinfest enabled auto-merge (squash) April 27, 2026 18:34
@bolinfest bolinfest disabled auto-merge April 27, 2026 18:37
@bolinfest bolinfest merged commit cafe717 into main Apr 27, 2026
41 of 44 checks passed
@bolinfest bolinfest deleted the pr19851 branch April 27, 2026 18:37
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants