Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e902ba021
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Set up Bazel | ||
| uses: bazelbuild/setup-bazelisk@b39c379c82683a5f25d34f0d062761f62693e0b2 # v3 | ||
| uses: ./.github/actions/setup-bazel-ci |
There was a problem hiding this comment.
Include setup-bazel-ci in v8-canary path filters
Now that this job depends on the local ./.github/actions/setup-bazel-ci action, the pull_request/push paths filters at the top of v8-canary.yml are incomplete: they still do not include the action path. As a result, PRs (and pushes) that change setup-bazel-ci can skip v8-canary entirely, so Bazel bootstrap regressions for V8 builds can merge without this workflow running. Add .github/actions/setup-bazel-ci/** (or equivalent) to both path-filter lists.
Useful? React with 👍 / 👎.
Why
All Bazel CI jobs are currently blocked in the
setup-bazeliskstep while trying to download Bazelisk.bazelbuild/setup-bazeliskis archived, and its README now recommends migrating tobazel-contrib/setup-bazel, so leaving our workflows on the archived action leaves CI exposed to exactly this sort of outage.Because
v8-canarynow consumes the shared localsetup-bazel-ciaction, that workflow also needs to trigger when the action changes. Without that follow-up, Bazel bootstrap regressions specific to the V8 canary path could be skipped by the workflow path filters.What Changed
.github/actions/setup-bazel-ci/action.ymlfrombazelbuild/setup-bazelisktobazel-contrib/setup-bazel, pinned to0.19.0.bazelisk-versionunset so GitHub-hosted runners can use their preinstalled Bazelisk instead of downloading1.xat job start..github/workflows/rusty-v8-release.ymland.github/workflows/v8-canary.ymlto use the sharedsetup-bazel-ciaction instead of referencingsetup-bazeliskdirectly..github/actions/setup-bazel-ci/**to thepull_requestandpushpath filters in.github/workflows/v8-canary.ymlso changes to the shared Bazel setup action still run the canary workflow.This keeps Bazel version selection anchored by
.bazelversionwhile removing the failing dependency on the archived setup action.Verification
.github/to confirm there are no remainingsetup-bazeliskreferences.YAML.load_file.