Show plugin hooks in plugin details#19859
Closed
abhinav-oai wants to merge 6 commits intoabhinav/hooks-browser-menufrom
Closed
Show plugin hooks in plugin details#19859abhinav-oai wants to merge 6 commits intoabhinav/hooks-browser-menufrom
abhinav-oai wants to merge 6 commits intoabhinav/hooks-browser-menufrom
Conversation
abhinav-oai
commented
Apr 27, 2026
| pub struct PluginHookSummary { | ||
| pub event_name: HookEventName, | ||
| pub handler_count: usize, | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
will expand with more metadata in the future
Collaborator
Author
There was a problem hiding this comment.
I think the follow-up shape should be per-handler rather than per-event:
PluginHookSummary {
key: String,
event_name: HookEventName,
matcher: Option<String>,
enabled: bool,
status_message: Option<String>,
definition: serde_json::Value,
display_order: i64,
}That is the smallest shape the app detail page needs to render the hook rows directly: event_name for the title, matcher + optional status_message for the compact description, enabled for the toggle state, definition for the JSON details modal, display_order so clients preserve backend/authored order, and key as the opaque handle for toggling one specific handler.
Collaborator
Author
There was a problem hiding this comment.
then from this we can derive the event+count we need for the TUI /plugins
…-hooks-plugin-detail
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
abhinav-oai
force-pushed
the
abhinav/plugin-hooks-plugin-detail
branch
from
9068881 to
68e62c4
Compare
xl-openai
approved these changes
Apr 29, 2026
abhinav-oai
added a commit
that referenced
this pull request
May 7, 2026
Supersedes the abandoned #19859, rebuilt on latest `main`. # Why PR #19705 adds discovery for hooks bundled with plugins, but `/plugins` still only shows skills, apps, and MCP servers. This follow-up makes bundled hooks visible in the same plugin detail view so users can inspect the full plugin surface in one place. We also need `PluginHookSummary` to populate Plugin Hooks in the app; `hooks/list` is not enough there because plugin detail needs to show hooks for disabled plugins too. # What - extend `plugin/read` with `PluginHookSummary` entries for bundled hooks - summarize plugin hooks while loading plugin details - render a `Hooks` row in the `/plugins` detail popup <img width="3456" height="848" alt="CleanShot 2026-04-27 at 11 45 34@2x" src="https://github.com/user-attachments/assets/fe3a38d6-a260-4351-8513-fb04c93d725b" />
Oreoxp
pushed a commit
to Oreoxp/codex-cli
that referenced
this pull request
May 7, 2026
Supersedes the abandoned openai#19859, rebuilt on latest `main`. # Why PR openai#19705 adds discovery for hooks bundled with plugins, but `/plugins` still only shows skills, apps, and MCP servers. This follow-up makes bundled hooks visible in the same plugin detail view so users can inspect the full plugin surface in one place. We also need `PluginHookSummary` to populate Plugin Hooks in the app; `hooks/list` is not enough there because plugin detail needs to show hooks for disabled plugins too. # What - extend `plugin/read` with `PluginHookSummary` entries for bundled hooks - summarize plugin hooks while loading plugin details - render a `Hooks` row in the `/plugins` detail popup <img width="3456" height="848" alt="CleanShot 2026-04-27 at 11 45 34@2x" src="https://github.com/user-attachments/assets/fe3a38d6-a260-4351-8513-fb04c93d725b" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #19705 adds discovery for hooks bundled with plugins, but
/pluginsstill only shows skills, apps, and MCP servers. This follow-up makes bundled hooks visible in the same plugin detail view so users can inspect the full plugin surface in one place.We'll also need this
PluginHookSummaryto populate the Plugin Hooks in the App. We can't usehooks/listthere because we need to be able to show the hooks for disabled plugins as well.What
plugin/readwithPluginHookSummaryentries containing each hook event name and handler countHooksrow in the/pluginsdetail popup