Skip to content

feat: split memories part 2#19860

Merged
jif-oai merged 12 commits intomainfrom
jif/move-memories-part-2
Apr 28, 2026
Merged

feat: split memories part 2#19860
jif-oai merged 12 commits intomainfrom
jif/move-memories-part-2

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Apr 27, 2026

Keep extracting memories out of core and moving the write trigger in the app-server
This is temporary and it should move at the client level as a follow-up
This makes core fully independant from codex-memories-write

@jif-oai jif-oai requested a review from a team as a code owner April 27, 2026 18:47
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 27, 2026

@codex review

1 similar comment
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 27, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48ca345b97

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/client.rs
Comment thread codex-rs/core/src/session/handlers.rs Outdated
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 27, 2026

@codex review

1 similar comment
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 27, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a650996b96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/memories/write/src/phase1.rs
Comment thread codex-rs/core/src/session/session.rs
Comment thread codex-rs/memories/write/src/runtime.rs
Comment thread codex-rs/memories/write/src/runtime.rs Outdated
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 28, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

let NewThread {
thread_id,
thread: review_thread,
session_configured,
..
} = self
.thread_manager
.fork_thread(
ForkSnapshot::Interrupted,
config,
rollout_path,
/*persist_extended_history*/ false,
self.request_trace_context(request_id).await,
)

P2 Badge Trigger memory startup for detached review threads

After startup triggering moved out of core, this detached-review fork path creates a new thread but never calls start_memories_startup_task. Eligible review threads can now skip phase-1/phase-2 entirely, so memory artifacts/state are not refreshed for those sessions.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/memories/write/src/phase1.rs
jif-oai and others added 2 commits April 28, 2026 11:24
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 28, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1861b1b560

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/session/session.rs
Comment thread codex-rs/memories/write/src/phase1.rs
@jif-oai jif-oai merged commit 431ebea into main Apr 28, 2026
25 checks passed
@jif-oai jif-oai deleted the jif/move-memories-part-2 branch April 28, 2026 11:03
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants