Conversation
owenlin0
left a comment
owenlin0
left a comment
There was a problem hiding this comment.
config-loading is tolerant if someone still has:
[features]
general_analytics = false/true
in their config.toml, right? I assume so but just wanted to double check
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78dc09da85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let ClientRequest::TurnStart { request_id, .. } | ||
| | ClientRequest::TurnSteer { request_id, .. } = &codex_request | ||
| { | ||
| self.analytics_events_client.track_request( | ||
| connection_id.0, |
There was a problem hiding this comment.
Removing the Feature::GeneralAnalytics guard here causes turn analytics to run for every turn/start and turn/steer. Configs that previously opted out with [features].general_analytics = false are now ignored (the key was removed from codex-rs/features/src/lib.rs), so telemetry resumes unless users also set [analytics].enabled = false, creating an unexpected privacy regression.
Useful? React with 👍 / 👎.
2 participants
No description provided.