Clarify network approval auto-review prompts#19907
Merged
maja-openai merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
dylan-hurd-oai
approved these changes
Apr 28, 2026
Collaborator
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
LGTM! could we add a snapshot test for this as well?
03fc0b7 to
d1789a7
Compare
d1789a7 to
b7beaa7
Compare
b7beaa7 to
2856cd0
Compare
c1f698f to
62d1c5f
Compare
Contributor
Author
|
[codex] Addressed in the latest branch updates: this PR now includes an insta snapshot test for the network access guardian prompt layout (codex_core__guardian__tests__network_access_guardian_prompt_layout). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Network access approval prompts were showing the generic retry reason, which made auto-review focus on the blocked connection instead of the command that caused it. This makes network approvals easier to assess by telling the reviewer to evaluate whether the triggering command was authorised by the user and within policy, and to treat the network call as acceptable when it is a reasonable consequence of that command.
What changed
NetworkAccesshas a dedicated branch.Network approval contextandNetwork access JSONinstead ofRetry reason/Planned action JSON.Verification
cargo test -p codex-core guardian::tests::build_guardian_prompt_items_explains_network_access_review_scope