Allow large remote app-server resume responses#19920
Merged
etraut-openai merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
canvrno-oai
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remote TUI resume uses the app-server websocket client. That client inherited tungstenite's default
16 MiBframe limit, so a large saved session could makethread/resumereturn a single JSON-RPC response frame that the client rejected before the TUI could deserialize or render it.Fixes #19837
What Changed
128 MiBmax frame/message size.>16 MiBJSON-RPC response frame and verifies the typed request succeeds.Note: This isn't a perfect fix. It really just moves the limit to a much larger value. I looked at a bunch of other potential fixes (both server-side and client-side), and they all involved significant complexity, had backward-compatibility impact, or impacted performance of common use cases. This simple fix should address the vast majority of remote use cases.
Verification
I reproed the problem locally using a long rollout. Verified that fix addresses connection drop.