Skip to content

Move local /resume cwd filtering into thread/list#19931

Merged
canvrno-oai merged 2 commits intomainfrom
canvrno/tui_resume_cwd_filter
Apr 28, 2026
Merged

Move local /resume cwd filtering into thread/list#19931
canvrno-oai merged 2 commits intomainfrom
canvrno/tui_resume_cwd_filter

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

@canvrno-oai canvrno-oai commented Apr 28, 2026

Move local resume and fork cwd filtering to thread/list instead of filtering in the TUI. This makes the /resume menu feel slightly faster to load when working in repos with many historical threads, and centralizes the cwd filtering in app-server.

Affected:

  • /resume from inside the TUI.
  • codex resume with no session ID and without --last
  • codex resume --all
  • codex fork with no session ID and without --last
  • codex fork --all

Not affected:

  • codex resume
  • codex fork
  • codex resume --last
  • codex fork --last

Steps to test performance improvement in a real Codex environment:

  • Launch codex resume using compiled binary in a directory that has seen many threads.
  • Launch codex resume using release binary in same directory.
  • Observe difference in time-to-full-page as threads load.

@canvrno-oai canvrno-oai marked this pull request as ready for review April 28, 2026 06:13
@canvrno-oai canvrno-oai changed the title Move local resume cwd filtering into thread/list Move local /resume cwd filtering into thread/list Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice code cleanup! It also appears to improve performance of the resume picker in the tui.

I built locally and ran it through some manual tests to look for regressions, and I didn't find any problems.

@canvrno-oai canvrno-oai merged commit bc5a1b9 into main Apr 28, 2026
25 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/tui_resume_cwd_filter branch April 28, 2026 17:35
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants