Skip to content

Restore TUI working status after steer message is set#19939

Merged
canvrno-oai merged 3 commits intomainfrom
canvrno/working_message_on_steer
Apr 29, 2026
Merged

Restore TUI working status after steer message is set#19939
canvrno-oai merged 3 commits intomainfrom
canvrno/working_message_on_steer

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

@canvrno-oai canvrno-oai commented Apr 28, 2026

Fix for #19925

Restore the Working indicator after a streamed final answer finishes when a user steer message is sent.
Add regression coverage for long output plus a mid-stream steer:
cargo test -p codex-tui final_answer_completion_restores_status_indicator_for_pending_steer

Duplication/testing steps:

  1. Start a new thread and ask for a long response.
  2. While the response is streaming, submit a steer message.
  3. When the first response finishes, observe whether Working... is shown while waiting for the steer message response.

@canvrno-oai canvrno-oai marked this pull request as ready for review April 28, 2026 17:56
@canvrno-oai canvrno-oai changed the title Restore TUI working status after pending steer Restore TUI working status after steer message is set Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@canvrno-oai canvrno-oai merged commit 24be9ac into main Apr 29, 2026
25 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/working_message_on_steer branch April 29, 2026 01:10
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants