Skip to content

Require remote plugin detail before uninstall#19966

Merged
xli-oai merged 2 commits intomainfrom
xli-codex/remote-plugin-uninstall-prefetch-detail
Apr 29, 2026
Merged

Require remote plugin detail before uninstall#19966
xli-oai merged 2 commits intomainfrom
xli-codex/remote-plugin-uninstall-prefetch-detail

Conversation

@xli-oai
Copy link
Copy Markdown
Contributor

@xli-oai xli-oai commented Apr 28, 2026

Summary

  • Fetch remote plugin detail before sending the uninstall request.
  • Use the detail response to derive the marketplace namespace and plugin name for cache cleanup.
  • Stop the uninstall before the backend POST if detail lookup fails, so backend state and local cache state do not diverge.

Testing

  • just fmt
  • cargo test -p codex-app-server plugin_uninstall
  • cargo test -p codex-core-plugins
  • git diff --check

@xli-oai xli-oai added the oai PRs contributed by OpenAI employees label Apr 28, 2026 — with ChatGPT Codex Connector
@xli-oai xli-oai marked this pull request as ready for review April 28, 2026 19:56
@xli-oai
Copy link
Copy Markdown
Contributor Author

xli-oai commented Apr 28, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@xli-oai xli-oai merged commit afbddab into main Apr 29, 2026
25 checks passed
@xli-oai xli-oai deleted the xli-codex/remote-plugin-uninstall-prefetch-detail branch April 29, 2026 21:01
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

oai PRs contributed by OpenAI employees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants