feat: trigger memories from user turns with cooldown by jif-oai · Pull Request #19970 · openai/codex

jif-oai · 2026-04-28T11:47:48Z

Why

Memory startup was tied to thread lifecycle events such as create, load, and fork. That can run memory work before a thread receives real user input, and it makes startup cost scale with thread management instead of actual turns. Moving the trigger to thread/sendInput keeps memory startup aligned with the first real user turn and lets it use the current thread config at turn time.

The idea is to prevent ghost cost due to pre-warm triggered by the app

Turn-based startup can also make global phase-2 consolidation easier to request repeatedly, so this adds a success cooldown and tightens the default startup scan window.

What Changed

Start codex_memories_write::start_memories_startup_task after a non-empty thread/sendInput turn is submitted, instead of from thread create/load/fork paths:

codex/codex-rs/app-server/src/codex_message_processor.rs

Lines 6477 to 6487 in d4a6885

    
           if turn_has_input { 
        
               let config_snapshot = thread.config_snapshot().await; 
        
               codex_memories_write::start_memories_startup_task( 
        
                   Arc::clone(&self.thread_manager), 
        
                   Arc::clone(&self.auth_manager), 
        
                   thread_id, 
        
                   Arc::clone(&thread), 
        
                   thread.config().await, 
        
                   &config_snapshot.session_source, 
        
               ); 
        
           }

Expose CodexThread::config() so app-server can pass the live config into memory startup at turn time.

Add a six-hour successful-run cooldown for global phase-2 consolidation via SkippedCooldown:

codex/codex-rs/state/src/runtime/memories.rs

Lines 963 to 966 in d4a6885

    
           if status == "done" && finished_at.is_some_and(|finished_at| finished_at > cooldown_cutoff) 
        
           { 
        
               tx.commit().await?; 
        
               return Ok(Phase2JobClaimOutcome::SkippedCooldown);

Reduce memory startup defaults to at most 2 rollouts over 10 days:

codex/codex-rs/config/src/types.rs

Lines 31 to 34 in d4a6885

    
           pub const DEFAULT_OTEL_ENVIRONMENT: &str = "dev"; 
        
           pub const DEFAULT_MEMORIES_MAX_ROLLOUTS_PER_STARTUP: usize = 2; 
        
           pub const DEFAULT_MEMORIES_MAX_ROLLOUT_AGE_DAYS: i64 = 10; 
        
           pub const DEFAULT_MEMORIES_MIN_ROLLOUT_IDLE_HOURS: i64 = 6;

Verification

Updated the memory runtime coverage around phase-2 reclaim behavior, including phase2_global_lock_respects_success_cooldown.

jif-oai · 2026-04-28T11:50:08Z

@codex review

Co-authored-by: Codex <noreply@openai.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6a051a98b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jif-oai · 2026-04-28T12:58:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c75cb9386f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jif-oai · 2026-04-28T13:14:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1592afbb03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jif-oai · 2026-04-28T13:38:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4a6885b78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jif-oai · 2026-04-28T14:08:24Z

@codex review

chatgpt-codex-connector · 2026-04-28T14:12:52Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

feat: trigger memories at first turn

b6a051a

jif-oai requested a review from a team as a code owner April 28, 2026 11:47

jif-oai changed the title ~~feat: trigger memories at first turn~~ Start memories only on first root turn Apr 28, 2026

jif-oai changed the title ~~Start memories only on first root turn~~ feat: trigger memories at first turn Apr 28, 2026

Merge origin/main into memories turn start

d3328a0

Co-authored-by: Codex <noreply@openai.com>

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated

Comment thread codex-rs/app-server/src/codex_message_processor.rs Outdated

jif-oai changed the title ~~feat: trigger memories at first turn~~ [do not merge]feat: trigger memories at first turn Apr 28, 2026

simplify it

c75cb93

jif-oai changed the title ~~[do not merge]feat: trigger memories at first turn~~ feat: trigger memories based on turns instead of threads Apr 28, 2026

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs

feat: memories cooldown

1592afb

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs

Comment thread codex-rs/app-server/src/codex_message_processor.rs

nits

d4a6885

jif-oai changed the title ~~feat: trigger memories based on turns instead of threads~~ feat: trigger memories from user turns with cooldown Apr 28, 2026

jif-oai mentioned this pull request Apr 28, 2026

Codex Desktop idle usage drain from background memory generation; stopped after generate_memories=false #19732

Closed

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs

Comment thread codex-rs/app-server/src/codex_message_processor.rs

Comment thread codex-rs/state/src/runtime/memories.rs Outdated

fix comment

21b9223

jif-oai merged commit a9e5c34 into main Apr 28, 2026
24 of 25 checks passed

jif-oai deleted the jif/memories-turn-start branch April 28, 2026 14:23

github-actions Bot locked and limited conversation to collaborators Apr 28, 2026

	if turn_has_input {
	let config_snapshot = thread.config_snapshot().await;
	codex_memories_write::start_memories_startup_task(
	Arc::clone(&self.thread_manager),
	Arc::clone(&self.auth_manager),
	thread_id,
	Arc::clone(&thread),
	thread.config().await,
	&config_snapshot.session_source,
	);
	}

	if status == "done" && finished_at.is_some_and(\|finished_at\| finished_at > cooldown_cutoff)
	{
	tx.commit().await?;
	return Ok(Phase2JobClaimOutcome::SkippedCooldown);

	pub const DEFAULT_OTEL_ENVIRONMENT: &str = "dev";
	pub const DEFAULT_MEMORIES_MAX_ROLLOUTS_PER_STARTUP: usize = 2;
	pub const DEFAULT_MEMORIES_MAX_ROLLOUT_AGE_DAYS: i64 = 10;
	pub const DEFAULT_MEMORIES_MIN_ROLLOUT_IDLE_HOURS: i64 = 6;

Conversation

jif-oai commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What Changed

Verification

Uh oh!

jif-oai commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jif-oai commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jif-oai commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jif-oai commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jif-oai commented Apr 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jif-oai commented Apr 28, 2026 •

edited

Loading