fix(tui): let esc exit empty shell mode#19986
Merged
fcoury-oai merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecb16c05c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ecb16c0 to
4457581
Compare
canvrno-oai
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escis pressed while the absorbed!is the only inputRoot cause
Shell mode stores the leading
!outside the editable textarea. After typing only!, the textarea is empty but the composer is still in bash mode, so the existing empty-composerEschandling never runs.Validation
just fmtcargo test -p codex-tui bottom_pane::chat_composer::tests::esc_exits_empty_shell_modecargo test -p codex-tui bottom_pane::chat_composer::tests::footer_mode_snapshotscargo insta pending-snapshotscargo test -p codex-tuistill reports unrelated existing/statussnapshot drift in this local environment because the rendered permissions text isworkspace-write with network accessinstead of the olderread-onlyfixture text.