fix(network-proxy): normalize network proxy host matching#19995
fix(network-proxy): normalize network proxy host matching#19995evawong-oai merged 5 commits intomainfrom
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex noreply@openai.com
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eebaeec607
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
|
Validation update
Ship decision: I think this is ready after review approval. |
|
Validation done against the readiness row for the scoped IPv6 denial bypass.
Verdict: this fixes the tracked policy bypass described in the readiness row. Remaining readiness work is merge plus validation on the final event build if the row is held to published build readiness. |
Why
The proxy matches allow and deny rules against normalized host strings. Scoped IPv6 literals can arrive in equivalent forms, such as
fd00::1%eth0,[fd00::1%eth0], or[fd00::1%25eth0]. Policy should canonicalize those spellings without erasing scope granularity: an unscoped rule likefd00::1should still cover scoped requests for that address, while a scoped rule likefd00::1%eth0should remain exact to that scope.What changed
%25scopeto%scopenetwork-proxySecurity impact
A request cannot bypass a broad deny rule by adding an IPv6 scope suffix. At the same time, scoped policy remains precise:
deny=fd00::1%eth0affects that scoped spelling without collapsingfd00::1%eth1onto the same key, andallow=fe80::1%eth0does not implicitly allow other scopes.Verification
just fmtcargo test -p codex-network-proxyjust fix -p codex-network-proxygit diff --check