fix(tui): update plan mode task completion test#20051
Closed
friel-openai wants to merge 2 commits intomainfrom
Closed
fix(tui): update plan mode task completion test#20051friel-openai wants to merge 2 commits intomainfrom
friel-openai wants to merge 2 commits intomainfrom
Conversation
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 28, 2026
… fix - anomalyco/opencode#24836 SDK-level integration tests for newly-wired routes - anomalyco/opencode#24835 wire global+control handlers and split routing - openai/codex#20051 unbreak trunk argument-comment-lint after #20046
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_mode_nudge_hides_while_task_or_modal_is_activefor the currenton_task_completesignatureWhy this is separate from #20046
codex-rs/protocol/src/protocol.rsupstream/mainalready has the stale two-argument call incodex-rs/tui/src/chatwidget/tests/plan_mode.rsupstream/mainalready has the three-argumenton_task_completesignature incodex-rs/tui/src/chatwidget.rsFailing jobs observed on #20046
Validation
just fmtjust argument-comment-lintcargo test -p codex-tui plan_mode_nudge_hides_while_task_or_modal_is_activedoes not reach the test on this machine becausecodex-linux-sandboxcannot build without systemlibcap; the GitHub jobs above show the pre-fix compiler failure in this test file.