Skip to content

Make MultiAgentV2 wait minimum configurable#20052

Merged
jif-oai merged 1 commit intomainfrom
jif/configurable-min-wait-timeout
Apr 28, 2026
Merged

Make MultiAgentV2 wait minimum configurable#20052
jif-oai merged 1 commit intomainfrom
jif/configurable-min-wait-timeout

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Apr 28, 2026

Why

MultiAgentV2 wait_agent currently clamps short waits to a fixed 10 second minimum. That default is still useful for preventing tight polling loops, but it is too rigid for environments that need faster mailbox wake-up checks or a larger minimum to discourage frequent polling.

This PR makes the minimum wait timeout configurable from the existing MultiAgentV2 feature config section, so operators can tune the behavior without changing the legacy multi-agent tool surface.

What Changed

  • Added features.multi_agent_v2.min_wait_timeout_ms.
  • Defaulted the new setting to the existing 10 second floor.
  • Validated the configured value as 1..=3600000, matching the existing one hour maximum wait bound.
  • Applied the configured minimum to MultiAgentV2 wait_agent runtime clamping.
  • Plumbed the configured minimum into the wait_agent tool schema, including the effective default when the minimum is above the normal 30 second default.
  • Regenerated core/config.schema.json.

Verification

  • cargo test -p codex-features
  • cargo test -p codex-tools
  • cargo test -p codex-core --lib multi_agent_v2
  • just fix -p codex-core

@jif-oai jif-oai requested a review from a team as a code owner April 28, 2026 18:13
@jif-oai jif-oai changed the title feat: configurable min wait timeout Make MultiAgentV2 wait minimum configurable Apr 28, 2026
@jif-oai jif-oai force-pushed the jif/configurable-min-wait-timeout branch from b72419c to eb9236b Compare April 28, 2026 19:58
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 28, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 34d71d4 into main Apr 28, 2026
25 checks passed
@jif-oai jif-oai deleted the jif/configurable-min-wait-timeout branch April 28, 2026 20:36
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants