Add environment provider snapshot#20058
Merged
starr-openai merged 5 commits intomainfrom Apr 29, 2026
Merged
Conversation
starr-openai
force-pushed
the
starr/environment-provider-snapshot
branch
from
7dc4e28 to
430fde2
Compare
starr-openai
force-pushed
the
starr/environment-provider-snapshot
branch
2 times, most recently
from
ee5489a to
c96c688
Compare
pakrym-oai
reviewed
Apr 28, 2026
starr-openai
force-pushed
the
starr/environment-provider-snapshot
branch
from
c96c688 to
f02bda7
Compare
pakrym-oai
reviewed
Apr 28, 2026
starr-openai
force-pushed
the
starr/environment-provider-snapshot
branch
2 times, most recently
from
3ee024e to
f8a9938
Compare
Separate provider-owned environment configuration listing from EnvironmentManager's concrete environment cache. The default provider preserves the existing CODEX_EXEC_SERVER_URL behavior while the manager keeps local environment ownership internal. Co-authored-by: Codex <noreply@openai.com>
starr-openai
force-pushed
the
starr/environment-provider-snapshot
branch
from
f8a9938 to
1526b2c
Compare
pakrym-oai
reviewed
Apr 28, 2026
| ); | ||
| environments.insert(id, Arc::new(environment)); | ||
| } | ||
| environments.insert( |
Collaborator
There was a problem hiding this comment.
interesting that this is not returned by the provider
Contributor
Author
There was a problem hiding this comment.
we have some places that depend on local env being there via local_environment, so I put this in EnvironmentManager itself to guarantee its set and configured properly. Then the env provider just provides external ones.
this is why:
DefaultProvider should probably also return the local one.
doesn't.
pakrym-oai
approved these changes
Apr 28, 2026
Collaborator
pakrym-oai
left a comment
pakrym-oai
left a comment
There was a problem hiding this comment.
DefaultProvider should probably also return the local one.
Can we return the full Environment?
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvironmentProviderto return concreteEnvironmentinstances instead ofEnvironmentConfigurations.DefaultEnvironmentProviderprovide the provider-visiblelocalenvironment plus optionalremoteenvironment fromCODEX_EXEC_SERVER_URL.EnvironmentManageras the concrete cache while exposing its own explicit local environment forlocal_environment()fallback paths.Validation
just fmtgit diff --check