[app-server] centralize client response analytics#20059
Merged
Conversation
4d09071 to
e18fa36
Compare
e18fa36 to
ee331bd
Compare
f92744f to
5eb6d76
Compare
ee331bd to
a66ec81
Compare
5eb6d76 to
0022641
Compare
a66ec81 to
a54d537
Compare
0022641 to
a1caa34
Compare
a54d537 to
bd238db
Compare
a1caa34 to
6a5df25
Compare
bd238db to
4607729
Compare
7223fa2 to
e593ec4
Compare
4607729 to
dd4447b
Compare
owenlin0
approved these changes
Apr 29, 2026
e593ec4 to
1c6108c
Compare
dd4447b to
91ec095
Compare
1c6108c to
2536ff7
Compare
91ec095 to
2d8059c
Compare
2d8059c to
13db003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The precursor PR keeps successful client responses typed until app-server's outgoing response seam. This follow-up uses that seam to move successful client-response analytics out of individual handlers and into the shared sender path, while keeping filtering decisions inside
codex-analytics.What changed
OutgoingMessageSender::send_response.AnalyticsEventsClient, so unrelated client traffic is ignored before cloning or boxing.Verification
cargo test -p codex-analyticscargo test -p codex-app-server outgoing_message::tests --lib