Skip to content

Include auto-review rollout in feedback uploads#20064

Merged
won-openai merged 3 commits intomainfrom
a-r_feedback_improvement
Apr 29, 2026
Merged

Include auto-review rollout in feedback uploads#20064
won-openai merged 3 commits intomainfrom
a-r_feedback_improvement

Conversation

@won-openai
Copy link
Copy Markdown
Collaborator

@won-openai won-openai commented Apr 28, 2026

Summary

  • include the live auto-review trunk rollout when /feedback uploads logs
  • upload that attachment as auto-review-rollout-<parent-thread-id>.jsonl so it is distinguishable from the parent rollout
  • show the same auto-review attachment name in the TUI consent popup

Scope

  • this only covers the live cached auto-review trunk for the current parent thread
  • it does not add durable historical parent->auto-review lookup
  • it does not add persisted rollout support for ephemeral parallel review forks

UI

Screenshot 2026-04-28 at 1 17 18 PM

Validation

  • cargo test -p codex-core cached_guardian_subagent_exposes_its_rollout_path
  • cargo test -p codex-feedback
  • cargo test -p codex-app-server
  • cargo test -p codex-tui feedback_upload_consent_popup_snapshot
  • cargo test -p codex-tui feedback_good_result_consent_popup_includes_connectivity_diagnostics_filename

Known unrelated local failures

  • cargo test -p codex-core currently fails in the pre-existing proxy env snapshot test tools::runtimes::tests::maybe_wrap_shell_lc_with_snapshot_keeps_user_proxy_env_when_proxy_inactive
  • cargo test -p codex-tui currently hits pre-existing status::* snapshot drift unrelated to this change

Follow-Up

  • persist parallel auto-review fork sessions so /feedback can include their rollout history too
  • attach each persisted fork as its own clearly named file, for example auto-review-rollout--fork .jsonl, instead of merging multiple Guardian sessions into one attachment
  • keep the same live-session-only scope initially; durable historical parent -> auto-review lookup can remain a separate decision if we later need feedback from resumed sessions

@won-openai won-openai marked this pull request as ready for review April 28, 2026 20:16
@won-openai won-openai requested a review from a team as a code owner April 28, 2026 20:16
Copy link
Copy Markdown
Collaborator

@dylan-hurd-oai dylan-hurd-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick clarification about FeedbackAttachmentPath, but otherwise looks reasonable!

Comment thread codex-rs/feedback/src/lib.rs Outdated
@won-openai won-openai merged commit 5cf0adb into main Apr 29, 2026
25 checks passed
@won-openai won-openai deleted the a-r_feedback_improvement branch April 29, 2026 18:44
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants