[codex-analytics] prevent stale guardian events from satisfying reused reviews#20080
Merged
[codex-analytics] prevent stale guardian events from satisfying reused reviews#20080
Conversation
52cb786 to
d1d02d5
Compare
Collaborator
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
Can we add an integration test for this?
d1d02d5 to
1bd6754
Compare
dylan-hurd-oai
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reused Guardian review trunks can still have older child-turn events queued when a later review starts. The review waiter currently accepts the first terminal event it sees from the shared child session, so a stale
TurnCompletecan be attributed to the new review. That produces impossible analytics combinations such as non-null TTFT with sub-10 ms completion latency and zero token deltas ontrunk_reusedreviews.What changed
Op::UserTurnsubmission.codex-rs/core/src/guardian/review_session.rs.Verification
cargo test -p codex-core guardian::review_session::tests::cargo clippy -p codex-core --tests -- -D warnings