Skip to content

Fix plugin list workspace settings test isolation#20086

Merged
canvrno-oai merged 1 commit intomainfrom
canvrno/fix-plugin-list-workspace-settings-home-isolation
Apr 29, 2026
Merged

Fix plugin list workspace settings test isolation#20086
canvrno-oai merged 1 commit intomainfrom
canvrno/fix-plugin-list-workspace-settings-home-isolation

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

@canvrno-oai canvrno-oai commented Apr 28, 2026

Fixes test that often fails locally when running cargo test

  • Add an app-server test helper that combines managed-config isolation with custom env overrides.
  • Isolate HOME / USERPROFILE in plugin-list workspace settings tests so host home marketplaces do not affect results.

@canvrno-oai canvrno-oai marked this pull request as ready for review April 28, 2026 23:40
@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@canvrno-oai canvrno-oai merged commit 4c39ad3 into main Apr 29, 2026
25 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/fix-plugin-list-workspace-settings-home-isolation branch April 29, 2026 01:34
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants