Skip to content

expand the set of core shell env vars for Windows.#20089

Merged
iceweasel-oai merged 5 commits intomainfrom
dev/iceweasel/windows-shell-core-env-vars
Apr 29, 2026
Merged

expand the set of core shell env vars for Windows.#20089
iceweasel-oai merged 5 commits intomainfrom
dev/iceweasel/windows-shell-core-env-vars

Conversation

@iceweasel-oai
Copy link
Copy Markdown
Collaborator

#13917 and #18248 correctly identify that

[shell_environment_policy]
inherit = "core"

is not functional on Windows because it carries an insufficient set of env vars.
This PR expands that to match the more functional set from the MCP client

Comment thread codex-rs/protocol/src/shell_environment.rs Outdated
Comment thread codex-rs/protocol/src/shell_environment.rs Outdated
Comment thread codex-rs/protocol/src/shell_environment.rs Outdated
@iceweasel-oai iceweasel-oai requested a review from bolinfest April 29, 2026 18:13
@iceweasel-oai iceweasel-oai enabled auto-merge (squash) April 29, 2026 18:17
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice: ty!

@iceweasel-oai iceweasel-oai merged commit 9d1e5df into main Apr 29, 2026
35 of 36 checks passed
@iceweasel-oai iceweasel-oai deleted the dev/iceweasel/windows-shell-core-env-vars branch April 29, 2026 19:23
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants