[tool_suggest] Improve tool_suggest triggering conditions.#20091
Merged
mzeng-openai merged 9 commits intomainfrom Apr 29, 2026
Merged
[tool_suggest] Improve tool_suggest triggering conditions.#20091mzeng-openai merged 9 commits intomainfrom
mzeng-openai merged 9 commits intomainfrom
Conversation
mzeng-openai
changed the title
mzeng-openai
commented
Apr 29, 2026
mzeng-openai
commented
Apr 29, 2026
sayan-oai
reviewed
Apr 29, 2026
sayan-oai
reviewed
Apr 29, 2026
sayan-oai
approved these changes
Apr 29, 2026
sayan-oai
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_suggestguidance so it prefers explicit plugin install requests, while still allowing a connector install when the relevant plugin is already installed and a needed connector from that plugin is missing.tool_suggestin parallel with other tools.Testing
cargo test -p codex-tools tool_suggestcargo test -p codex-core tool_suggest