Skip to content

Increase plugin hook env test timeout#20100

Merged
abhinav-oai merged 2 commits intomainfrom
abhinav/fix-plugin-hook-timeout
Apr 29, 2026
Merged

Increase plugin hook env test timeout#20100
abhinav-oai merged 2 commits intomainfrom
abhinav/fix-plugin-hook-timeout

Conversation

@abhinav-oai
Copy link
Copy Markdown
Collaborator

@abhinav-oai abhinav-oai commented Apr 28, 2026

Why

plugin_hook_sources_run_with_plugin_env_and_plugin_source can still fail on Windows after the earlier file-based assertion cleanup because the hook process itself occasionally exceeds the old 5s timeout under CI load. When that happens, the hook run ends as Failed before the test can inspect its structured output.

The Windows Bazel failure showed the hook run itself failing after nearly 8 seconds:

---- engine::tests::plugin_hook_sources_run_with_plugin_env_and_plugin_source stdout ----
thread 'engine::tests::plugin_hook_sources_run_with_plugin_env_and_plugin_source' panicked at hooks/src\engine\mod_tests.rs:428:5:
assertion failed: `(left == right)`
Diff < left / right > :
<Failed
>Completed
...
test result: FAILED. 78 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.96s

What

  • raise the flaky plugin hook env test timeout from 5s to 10s so it matches the other executed hook tests in this module

Validation

  • cargo test -p codex-hooks

@abhinav-oai abhinav-oai force-pushed the abhinav/fix-plugin-hook-timeout branch from c152afb to 94f3287 Compare April 28, 2026 23:38
@abhinav-oai abhinav-oai enabled auto-merge (squash) April 28, 2026 23:40
@abhinav-oai abhinav-oai disabled auto-merge April 29, 2026 00:05
@abhinav-oai abhinav-oai enabled auto-merge (squash) April 29, 2026 00:06
Copy link
Copy Markdown
Contributor

@eternal-openai eternal-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved though I'm concerned that if this took 8s it could still in theory fail at 10s sometimes

@abhinav-oai abhinav-oai merged commit 5b0d9df into main Apr 29, 2026
25 checks passed
@abhinav-oai abhinav-oai deleted the abhinav/fix-plugin-hook-timeout branch April 29, 2026 00:08
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants