Increase plugin hook env test timeout#20100
Merged
abhinav-oai merged 2 commits intomainfrom Apr 29, 2026
Merged
Conversation
c152afb to
94f3287
Compare
eternal-openai
approved these changes
Apr 29, 2026
Contributor
eternal-openai
left a comment
There was a problem hiding this comment.
approved though I'm concerned that if this took 8s it could still in theory fail at 10s sometimes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
plugin_hook_sources_run_with_plugin_env_and_plugin_sourcecan still fail on Windows after the earlier file-based assertion cleanup because the hook process itself occasionally exceeds the old 5s timeout under CI load. When that happens, the hook run ends asFailedbefore the test can inspect its structured output.The Windows Bazel failure showed the hook run itself failing after nearly 8 seconds:
What
Validation
cargo test -p codex-hooks