Skip to content

feat: update Bedrock Mantle endpoint and GPT-5.4 model ID #20109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
celia-oai merged 1 commit into from
Apr 29, 2026
Merged

feat: update Bedrock Mantle endpoint and GPT-5.4 model ID #20109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codex-rs/model-provider-info/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ const OPENAI_PROVIDER_NAME: &str = "OpenAI";
pub const OPENAI_PROVIDER_ID: &str = "openai";
const AMAZON_BEDROCK_PROVIDER_NAME: &str = "Amazon Bedrock";
pub const AMAZON_BEDROCK_PROVIDER_ID: &str = "amazon-bedrock";
pub const AMAZON_BEDROCK_DEFAULT_BASE_URL: &str = "https://bedrock-mantle.us-east-1.api.aws/v1";
pub const AMAZON_BEDROCK_DEFAULT_BASE_URL: &str =
"https://bedrock-mantle.us-east-1.api.aws/openai/v1";
const CHAT_WIRE_API_REMOVED_ERROR: &str = "`wire_api = \"chat\"` is no longer supported.\nHow to fix: set `wire_api = \"responses\"` in your provider config.\nMore info: https://github.com/openai/codex/discussions/7782";
pub const LEGACY_OLLAMA_CHAT_PROVIDER_ID: &str = "ollama-chat";
pub const OLLAMA_CHAT_PROVIDER_REMOVED_ERROR: &str = "`ollama-chat` is no longer supported.\nHow to fix: replace `ollama-chat` with `ollama` in `model_provider`, `oss_provider`, or `--local-provider`.\nMore info: https://github.com/openai/codex/discussions/7782";
Expand Down
2 changes: 1 addition & 1 deletion codex-rs/model-provider-info/src/model_provider_info_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ fn test_create_amazon_bedrock_provider() {
ModelProviderInfo::create_amazon_bedrock_provider(/*aws*/ None),
ModelProviderInfo {
name: "Amazon Bedrock".to_string(),
base_url: Some("https://bedrock-mantle.us-east-1.api.aws/v1".to_string()),
base_url: Some("https://bedrock-mantle.us-east-1.api.aws/openai/v1".to_string()),
env_key: None,
env_key_instructions: None,
experimental_bearer_token: None,
Expand Down
2 changes: 1 addition & 1 deletion codex-rs/model-provider/src/amazon_bedrock/catalog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use codex_protocol::openai_models::WebSearchToolType;
const GPT_OSS_CONTEXT_WINDOW: i64 = 128_000;
const GPT_5_4_CONTEXT_WINDOW: i64 = 272_000;
const GPT_5_4_MAX_CONTEXT_WINDOW: i64 = 1_000_000;
const GPT_5_4_CMB_MODEL_ID: &str = "openai.gpt-5.4-cmb";
const GPT_5_4_CMB_MODEL_ID: &str = "openai.gpt-5.4";

pub(crate) fn static_model_catalog() -> ModelsResponse {
ModelsResponse {
Expand Down
4 changes: 2 additions & 2 deletions codex-rs/model-provider/src/amazon_bedrock/mantle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ pub(super) fn region_from_config(aws: &ModelProviderAwsAuthInfo) -> Option<Strin

pub(super) fn base_url(region: &str) -> Result<String> {
if BEDROCK_MANTLE_SUPPORTED_REGIONS.contains(&region) {
Ok(format!("https://bedrock-mantle.{region}.api.aws/v1"))
Ok(format!("https://bedrock-mantle.{region}.api.aws/openai/v1"))
} else {
Err(CodexErr::Fatal(format!(
"Amazon Bedrock Mantle does not support region `{region}`"
Expand All @@ -55,7 +55,7 @@ mod tests {
fn base_url_uses_region_endpoint() {
assert_eq!(
base_url("ap-northeast-1").expect("supported region"),
"https://bedrock-mantle.ap-northeast-1.api.aws/v1"
"https://bedrock-mantle.ap-northeast-1.api.aws/openai/v1"
);
}

Expand Down
2 changes: 1 addition & 1 deletion codex-rs/model-provider/src/amazon_bedrock/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ mod tests {

assert_eq!(
api_provider.base_url,
"https://bedrock-mantle.eu-central-1.api.aws/v1"
"https://bedrock-mantle.eu-central-1.api.aws/openai/v1"
);
}

Expand Down
4 changes: 2 additions & 2 deletions codex-rs/model-provider/src/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ mod tests {
assert_eq!(
model_ids,
vec![
"openai.gpt-5.4-cmb",
"openai.gpt-5.4",
"openai.gpt-oss-120b",
"openai.gpt-oss-20b"
]
Expand All @@ -474,7 +474,7 @@ mod tests {
.find(|preset| preset.is_default)
.expect("Bedrock catalog should have a default model");

assert_eq!(default_model.model, "openai.gpt-5.4-cmb");
assert_eq!(default_model.model, "openai.gpt-5.4");
}

#[tokio::test]
Expand Down
Loading