fix(sandboxing): Bound advisory system bwrap startup probe#20111
Merged
viyatb-oai merged 3 commits intomainfrom May 5, 2026
Merged
fix(sandboxing): Bound advisory system bwrap startup probe#20111viyatb-oai merged 3 commits intomainfrom
viyatb-oai merged 3 commits intomainfrom
Conversation
Co-authored-by: Codex noreply@openai.com
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7db3018aa7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
rreichel3-oai
approved these changes
May 5, 2026
Contributor
rreichel3-oai
left a comment
There was a problem hiding this comment.
Looks good, discussed offline to ensure that this wouldn't cause timeouts for /dev and /proc and other special FS mount points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Linux startup runs an advisory system
bwrapwarning probe on each launch. On hosts with NFS or autofs mounts, its--ro-bind / /probe can take tens of seconds before Codex prints anything, matching #19828. Because this probe only decides whether to surface a warning, it should not be allowed to stall startup.Relevant pre-change path:
codex-rs/sandboxing/src/bwrap.rsWhat changed
bwrapprobe to 500 ms.bwrappromptly reports a known user-namespace failure.bwrapprocess and a fake probe whose descendant keeps stderr open.Security
This only bounds the advisory startup probe. It does not change the command execution path or add a fail-open sandbox fallback. The related command-side hang in #20017 remains separate from this PR.
Verification
system_bwrap_probe_times_out_without_reporting_a_warning.system_bwrap_probe_does_not_wait_for_descendants_holding_stderr_open.cargo test -p codex-sandboxingcargo clippy -p codex-sandboxing --all-targets -- -D warningsFixes #19828
Related: #20017