[rollout-tracer] Match analysis messages on encrypted id.#20123
Merged
cassirer-openai merged 2 commits intomainfrom Apr 29, 2026
Merged
[rollout-tracer] Match analysis messages on encrypted id.#20123cassirer-openai merged 2 commits intomainfrom
cassirer-openai merged 2 commits intomainfrom
Conversation
In some setups the summary or raw content can be dropped between requests. This triggers a check in the reducer which expects that the messages should remain identical between requests. This PR relaxes the checks to only focus on the encrypted ID instead. It also changes the reducer to keep the most rich version of the message observed during the rollout (this ensures that we don't accidently lose the CoT nor summary when available).
jif-oai
approved these changes
Apr 29, 2026
| // an ordered superset so a later sighting can add summary/text while a | ||
| // conflicting sighting cannot overwrite the first readable body. | ||
| let mut incoming_iter = incoming_parts.iter(); | ||
| existing_parts.len() < incoming_parts.len() |
Collaborator
There was a problem hiding this comment.
This still drops complementary readable reasoning. If one sighting has only raw text and a later sighting has only summary for the same encrypted_content, neither body is a superset, so we never keep both. Can we merge non-conflicting text/summary observations instead of requiring the incoming body to contain all existing readable parts?
Contributor
Author
There was a problem hiding this comment.
Yeah I don't think that will ever happen in practice but seems reasonable so updated the code.
cassirer-openai
deleted the
cassirer/04-28/match-on-id-rather-than-content
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some setups the summary or raw content can be dropped between requests. This triggers a check in the reducer which expects that the messages should remain identical between requests.
This PR relaxes the checks to only focus on the encrypted ID instead. It also changes the reducer to keep the most rich version of the message observed during the rollout (this ensures that we don't accidentally lose the CoT nor summary when available).