Skip to content

Delete multi_agent_v2 followup_task interrupt parameter#20139

Merged
andmis merged 5 commits intomainfrom
andrey/delete-interrupt-parameter
Apr 29, 2026
Merged

Delete multi_agent_v2 followup_task interrupt parameter#20139
andmis merged 5 commits intomainfrom
andrey/delete-interrupt-parameter

Conversation

@andmis
Copy link
Copy Markdown
Collaborator

@andmis andmis commented Apr 29, 2026

Messages sent with followup_task already arrive at their target recipient promptly (at message boundaries while sampling, or after the pending tool call completes) -- having interrupt is not worth the added complexity.

@andmis andmis requested a review from a team as a code owner April 29, 2026 05:02
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

description,
"Send a string message to an existing agent without triggering a new turn."
);

P1 Badge Update send_message description assertion for new wording

create_send_message_tool() now returns a different description string, but this test still asserts the old exact text. The test will fail deterministically after this commit, causing false-negative CI failures in codex-tools.


assert!(properties.contains_key("interrupt"));

P1 Badge Align followup_task test with removed interrupt field

The commit removes interrupt from followup_task, but this test still requires the interrupt property (and checks its description). That makes the unit test fail every run, so the suite no longer reflects intended behavior.


assert!(ops_for_agent.iter().any(|op| matches!(op, Op::Interrupt)));

P1 Badge Drop stale interrupt assertions in followup_task tests

followup_task no longer issues an explicit interrupt, but this integration test still expects Op::Interrupt and interrupted-turn markers. It now fails for the new behavior and blocks/obscures regression signal in multi-agent test coverage.


wait_for_turn_aborted(&thread, &interrupted_turn_id, TurnAbortReason::Interrupted).await;

P1 Badge Remove obsolete interrupted-wait in marker-disabled test

followup_task no longer explicitly interrupts active turns, but this test still waits for TurnAbortReason::Interrupted. In this scenario it can hang or fail waiting for an abort event that is no longer guaranteed, making the test inconsistent with the new behavior.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tools/src/agent_tool_tests.rs Outdated
@andmis
Copy link
Copy Markdown
Collaborator Author

andmis commented Apr 29, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@andmis andmis merged commit 857146b into main Apr 29, 2026
25 checks passed
@andmis andmis deleted the andrey/delete-interrupt-parameter branch April 29, 2026 06:19
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants