Delete multi_agent_v2 followup_task interrupt parameter#20139
Conversation
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/tools/src/agent_tool_tests.rs
Lines 155 to 157 in e3b8c1f
create_send_message_tool() now returns a different description string, but this test still asserts the old exact text. The test will fail deterministically after this commit, causing false-negative CI failures in codex-tools.
codex/codex-rs/tools/src/agent_tool_tests.rs
Line 192 in e3b8c1f
The commit removes interrupt from followup_task, but this test still requires the interrupt property (and checks its description). That makes the unit test fail every run, so the suite no longer reflects intended behavior.
followup_task no longer issues an explicit interrupt, but this integration test still expects Op::Interrupt and interrupted-turn markers. It now fails for the new behavior and blocks/obscures regression signal in multi-agent test coverage.
followup_task no longer explicitly interrupts active turns, but this test still waits for TurnAbortReason::Interrupted. In this scenario it can hang or fail waiting for an abort event that is no longer guaranteed, making the test inconsistent with the new behavior.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Messages sent with
followup_taskalready arrive at their target recipient promptly (at message boundaries while sampling, or after the pending tool call completes) -- havinginterruptis not worth the added complexity.