Skip to content

TUI: Remove core protocol dependency [1/7]#20172

Merged
etraut-openai merged 1 commit intomainfrom
etraut/tui-cleanup-1
Apr 29, 2026
Merged

TUI: Remove core protocol dependency [1/7]#20172
etraut-openai merged 1 commit intomainfrom
etraut/tui-cleanup-1

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

Why

This is part 1 of a 7-PR stack to remove direct codex_protocol::protocol usage from codex-tui while keeping each layer reviewable and shippable.

This first layer reduces the size of the later chatwidget diff by mechanically moving MCP startup bookkeeping out of the central widget file without changing the event shapes or behavior.

What changed

  • Extracted MCP startup status handling into tui/src/chatwidget/mcp_startup.rs.
  • Kept the existing core event types in place for this purely mechanical move.
  • Updated the MCP startup tests to import the moved test-only event types directly.

Verification

  • cargo test -p codex-tui chatwidget::tests::mcp_startup

Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a smoke test with one MCP server that is always broken both on the current stable version and in this branch. Also compared the output of /mcp after boot and they are identical.

Code looks good, approved.

@etraut-openai etraut-openai merged commit 1c420a9 into main Apr 29, 2026
25 checks passed
@etraut-openai etraut-openai deleted the etraut/tui-cleanup-1 branch April 29, 2026 16:10
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants