TUI: Remove core protocol dependency [3/7]#20174
Merged
etraut-openai merged 3 commits intomainfrom Apr 29, 2026
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 595b7488ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
etraut-openai
added a commit
that referenced
this pull request
Apr 29, 2026
etraut-openai
force-pushed
the
etraut/tui-cleanup-3
branch
from
3133324 to
cc0c379
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-2
branch
from
6cc2aa2 to
e2a8ea5
Compare
etraut-openai
force-pushed
the
etraut/tui-cleanup-3
branch
from
159c23c to
4483cf0
Compare
fcoury-oai
approved these changes
Apr 29, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Ran the following manual testing: interrupting a running conversion, renaming a session and using the new name to restart it and /compact. They all worked as expected.
Code looks good. Approved.
etraut-openai
force-pushed
the
etraut/tui-cleanup-3
branch
from
4483cf0 to
f27d4aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is part 3 of a 7-PR stack to remove direct
codex_protocol::protocolusage fromcodex-tuiwhile keeping each layer reviewable and shippable.With
AppCommandnow explicit, the internal app event bus can carry TUI commands directly instead of bouncing through coreOpvalues.What changed
AppEvent::CodexOpandAppEvent::SubmitThreadOpto carryAppCommand.AppCommandvalues.AppCommandor convert back throughinto_core()where they intentionally assert legacy payload equality.Verification
cargo test -p codex-tui --no-run