Make multi-agent v2 ignore agents.max_depth#20180
Merged
Conversation
jif-oai
changed the title
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
aibrahim-oai
approved these changes
Apr 29, 2026
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
Apr 29, 2026
- anomalyco/opencode#24923 apiKeyCommand provider option (merge-after-nits) - anomalyco/opencode#24921 per-target dependency install loop (merge-after-nits) - openai/codex#20180 carve agents.max_depth out of multi-agent v2 (merge-after-nits)
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
agents.max_depthis a legacy multi-agent v1 guard. Multi-agent v2 uses task-path routing and its own session/thread limits, so v2 should not reject nestedspawn_agentcalls just because the thread-spawn depth has reached the v1 maximum.Keeping the v1 depth guard active in v2 prevents deeper task trees even though the v2 path still needs the depth value only for lineage and task-path metadata.
What Changed
spawn_agenthandler while still computing child depth for lineage/path metadata.SpawnCsv/Collabtools apply only whenFeature::MultiAgentV2is disabled.multi_agent_v2_spawn_agent_ignores_configured_max_depthto cover a v2 child spawning another agent whenagent_max_depth = 1, while the existing v1 depth-limit tests continue to enforce the legacy behavior.Verification
cargo test -p codex-core multi_agent_v2_spawn_agent_ignores_configured_max_depth -- --nocapturecargo test -p codex-core depth_limit -- --nocapturecargo test -p codex-core tools::handlers::multi_agents::tests -- --nocapture