app-server: remove dead api version handling from bespoke events#20291
Merged
pakrym-oai merged 1 commit intomainfrom Apr 30, 2026
Merged
app-server: remove dead api version handling from bespoke events#20291pakrym-oai merged 1 commit intomainfrom
pakrym-oai merged 1 commit intomainfrom
Conversation
pakrym-oai
force-pushed
the
pakrym/remove-bespoke-api-version
branch
from
1d599e1 to
224ead8
Compare
etraut-openai
approved these changes
Apr 30, 2026
Collaborator
etraut-openai
left a comment
etraut-openai
left a comment
There was a problem hiding this comment.
Codex reordered event handlers in bespoke_event_handling, so I wasn't able to verify with certainty that the new code is equivalent, but I spot checked it, and it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove ApiVersion::V1